-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change labels to only consider reviews from users with push access #23
Conversation
Seems fine. Is there a way to test it? |
It's not the easiest, you'd need to pull it down, build, start, and follow the installation/usage/configuration instructions in the README to set up a github bot on your account, then create a test repo and install the bot there. I've tested to make sure it works as expected. |
Updated to ignore non-push reviews regardless of type (as discussed in #18) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks fine. Ill approve for now if it's working in your test env. It would still be nice if @twk3 could look it over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me as well. 👍
Looks like the review labels aren't working any more. They did work on my local tests so I can only assume that the setup of the actual repos is different. Is there any way we can debug in-situ with netlify if I get a PR up to add some logging? |
@matt-fidd yes, if you ask mattis for access, the logs are available here: https://app.netlify.com/sites/actual-gh-bot/logs/functions/webhooks (there aren't currently any errors being logged, just probot info messages).
|
Thanks @twk3, I've asked on Discord. Will get a PR up for extra logging quickly. |
Fixes #18