Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change labels to only consider reviews from users with push access #23

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

matt-fidd
Copy link
Collaborator

Fixes #18

@matt-fidd matt-fidd requested review from twk3 and youngcw August 5, 2024 23:13
@actual-github-bot actual-github-bot bot changed the title Change approved label to only consider reviews from users with push access [WIP] Change approved label to only consider reviews from users with push access Aug 5, 2024
@matt-fidd matt-fidd changed the title [WIP] Change approved label to only consider reviews from users with push access Change approved label to only consider reviews from users with push access Aug 5, 2024
@youngcw
Copy link
Member

youngcw commented Aug 7, 2024

Seems fine. Is there a way to test it?

@matt-fidd
Copy link
Collaborator Author

It's not the easiest, you'd need to pull it down, build, start, and follow the installation/usage/configuration instructions in the README to set up a github bot on your account, then create a test repo and install the bot there.

I've tested to make sure it works as expected.

@matt-fidd
Copy link
Collaborator Author

Updated to ignore non-push reviews regardless of type (as discussed in #18)

@matt-fidd matt-fidd changed the title Change approved label to only consider reviews from users with push access Change labels to only consider reviews from users with push access Aug 10, 2024
Copy link
Member

@youngcw youngcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks fine. Ill approve for now if it's working in your test env. It would still be nice if @twk3 could look it over.

Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me as well. 👍

@matt-fidd matt-fidd merged commit df93c0e into main Aug 13, 2024
3 checks passed
@matt-fidd matt-fidd deleted the matt/maintainer-approval branch August 13, 2024 01:57
@matt-fidd
Copy link
Collaborator Author

matt-fidd commented Aug 14, 2024

Looks like the review labels aren't working any more. They did work on my local tests so I can only assume that the setup of the actual repos is different.

Is there any way we can debug in-situ with netlify if I get a PR up to add some logging?

@twk3
Copy link
Contributor

twk3 commented Aug 14, 2024

@matt-fidd yes, if you ask mattis for access, the logs are available here: https://app.netlify.com/sites/actual-gh-bot/logs/functions/webhooks (there aren't currently any errors being logged, just probot info messages).

Aug 14, 06:13:57 AM: d6585730 INFO (probot): loading app
Aug 14, 06:13:57 AM: d6585730 INFO (probot): probot loaded
Aug 14, 06:13:57 AM: d6585730 INFO (probot): webhook verified
Aug 14, 06:13:58 AM: d6585730 Duration: 1138.36 ms	Memory Usage: 144 MB	Init Duration: 454.96 ms
Aug 14, 07:12:40 AM: dac3cc79 INFO (probot): loading app
Aug 14, 07:12:40 AM: dac3cc79 INFO (probot): probot loaded
Aug 14, 07:12:40 AM: dac3cc79 INFO (probot): webhook verified
Aug 14, 07:12:42 AM: dac3cc79 Duration: 1027.19 ms	Memory Usage: 144 MB	Init Duration: 393.56 ms
Aug 14, 07:12:47 AM: 5053dae0 INFO (probot): loading app
Aug 14, 07:12:47 AM: 5053dae0 INFO (probot): probot loaded
Aug 14, 07:12:47 AM: 5053dae0 INFO (probot): webhook verified
Aug 14, 07:12:47 AM: 5053dae0 Duration: 905.84 ms	Memory Usage: 144 MB
Aug 14, 07:12:48 AM: 04987769 INFO (probot): loading app
Aug 14, 07:12:48 AM: 04987769 INFO (probot): probot loaded
Aug 14, 07:12:48 AM: 04987769 INFO (probot): webhook verified
Aug 14, 07:12:48 AM: 04987769 Duration: 7.81 ms	Memory Usage: 144 MB
Aug 14, 07:12:48 AM: 729346e4 INFO (probot): loading app
Aug 14, 07:12:48 AM: 729346e4 INFO (probot): probot loaded
Aug 14, 07:12:48 AM: 729346e4 INFO (probot): webhook verified
Aug 14, 07:12:48 AM: 729346e4 Duration: 4.40 ms	Memory Usage: 144 MB

@matt-fidd
Copy link
Collaborator Author

Thanks @twk3, I've asked on Discord.

Will get a PR up for extra logging quickly.

@matt-fidd matt-fidd mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only Approve with maintainer approval
3 participants