Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent erroneous approved label when no review status is submitted #15

Merged
merged 1 commit into from
Jul 8, 2024
Merged

prevent erroneous approved label when no review status is submitted #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/classes/PullRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export default class PullRequest {
}

async getReviewStatus(): Promise<
'changesRequested' | 'needsMoreApprovals' | 'approved'
'changesRequested' | 'needsMoreApprovals' | 'approved' | undefined
> {
const reviews = (
await this.octokit.pulls.listReviews({
Expand All @@ -119,6 +119,8 @@ export default class PullRequest {
['APPROVED', 'CHANGES_REQUESTED'].includes(r.state),
);

if (reviews.length < 1) return;

const latestReviewsObj: { [key: number]: { state: string; time: number } } =
{};

Expand Down
2 changes: 2 additions & 0 deletions src/handlers/pullRequestReview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ export default (app: Probot) => {
const pr = new PullRequest(context);
const reviewStatus = await pr.getReviewStatus();

if (!reviewStatus) return;

await pr.addLabel(reviewStatus);
});
};