improve: Reduce transaction submission retries #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two layers of transaction submission at play - one at the quorum provider level, and one above. The quorum provider ensures that transactions are submitted successively to each provider until success or failure. The upper layer then implements its own retry mechanism, currently at 2 retries. This ultimately results in a _lot_ of attempts to submit transactions, which causes delays when the transaction is inherently unable to be submitted (i.e. due to nonce issues).
pxrl
requested review from
mrice32,
nicholaspai,
james-a-morris,
dohaki and
bmzig
as code owners
nicholaspai
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there are multiple providers for each chain, reduce the number of retries on transaction submission to speed-up the case where a transaction is actually unable to be submitted.
There are two layers of transaction submission at play - one at the quorum provider level, and one above. The quorum provider ensures that transactions are submitted successively to each provider until success or failure. For most chains, this means that transactions are submitted to 2 - 3 providers per retry. The upper layer then implements its own retry mechanism, currently at 2 retries. In cases where the transaction is ultimately unable to be submitted (i.e. underpriced replacement), this results in multiple futile submission attempts.