[WIP] improve(TransactionUtils): Simple priority scaler for replacement transactions #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsactions If transaction submission fails and the word "underpriced" is found in the error message, request that the priority fee be increased on the subsequent retry. This isn't foolproof but is cheap to try and makes sense as an initial step towards successfully submitting replacement transactions during gas price spikes.
pxrl
commented
Feb 25, 2025
| @@ -88,6 +90,15 @@ export async function runTransaction( | |||
| await contract.populateTransaction[method](...(args as Array<unknown>), { value }) | |||
| ); | |||
|
|
|||
| // Bump the priority fee by 20% to try to successfully replace a pending transaction. | |||
| // Success is not guaranteed since the bot does not know the gas price of the transaction it is trying to replace. | |||
| if (bumpGas && gas.maxPriorityFeePerGas) { | |||
There was a problem hiding this comment.
Legacy transactions are currently ignored since issues have only been seen on eip-1559 chains. It would make sense to scale legacy transactions though.
pxrl
commented
Feb 25, 2025
| // Bump the priority fee incrementally on each retry to try to successfully replace a pending transaction. | ||
| // Success is not guaranteed since the bot does not know the gas price of the transaction it is trying to replace. | ||
| if (bumpGas && gas.maxPriorityFeePerGas) { | ||
| const priorityScaler = 1.1 + (1 + DEFAULT_RETRIES - Math.min(retriesRemaining, DEFAULT_RETRIES)) / 10; |
There was a problem hiding this comment.
At least some aspect of this scaler should probably be configurable.
pxrl
commented
Feb 25, 2025
| @@ -118,7 +132,8 @@ export async function runTransaction( | |||
| retriesRemaining, | |||
| }); | |||
|
|
|||
| return await runTransaction(logger, contract, method, args, value, gasLimit, null, retriesRemaining); | |||
| const bumpGas = isEthersError(error) && error.message.toLowerCase().includes("underpriced"); | |||
There was a problem hiding this comment.
todo: link up more cleanly with the provider layer. The provider layer should be able to explicitly identify these cases and tag them with a code we can evaluate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If transaction submission fails and the word "underpriced" is found in the error message, request that the current estimated priority fee be increased on the subsequent retry.
This isn't foolproof but is cheap to try and makes sense as an initial step towards successfully submitting replacement transactions during gas price spikes.
This can be improved at least by aligning with the provider layer to supply an objective code that indicates an underpriced transaction, rather than having to rely on string matching. It would additionally be beneficial to be able to source the actual gas price of for other transactions with the same nonce. This however involves additional RPC queries.
(PR is WIP and will be iterated on)