Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement conversion from LaTeX to our Markup XML #4787

Draft
wants to merge 3 commits into
base: python-dev
Choose a base branch
from

Conversation

mbollmann
Copy link
Member

This reimplements functionality from bin/latex_to_unicode.py within the new library, needed for #4766.

Work in progress. Works in principle, but needs much more test cases to ensure feature parity with the previous implementation. Also, some normalization steps (as done in the old latex_to_unicode() function) are not yet ported.

This reimplements most of `bin/latex_to_unicode.py` within the new library.
More tests are needed, and some conversions done in `latex_to_unicode` are still missing.
@mbollmann mbollmann added the python-library Concerning the acl-anthology-py library label Mar 5, 2025
@mbollmann mbollmann self-assigned this Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 93.25843% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.64%. Comparing base (505a099) to head (28e6a0b).

Files with missing lines Patch % Lines
python/acl_anthology/utils/latex.py 92.10% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           python-dev    #4787      +/-   ##
==============================================
+ Coverage       92.62%   92.64%   +0.01%     
==============================================
  Files              35       35              
  Lines            2645     2733      +88     
==============================================
+ Hits             2450     2532      +82     
- Misses            195      201       +6     
Files with missing lines Coverage Δ
python/acl_anthology/text/markuptext.py 95.19% <100.00%> (+0.19%) ⬆️
python/acl_anthology/utils/__init__.py 100.00% <100.00%> (ø)
python/acl_anthology/utils/xml.py 98.57% <100.00%> (+0.18%) ⬆️
python/acl_anthology/utils/latex.py 96.12% <92.10%> (-3.88%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python-library Concerning the acl-anthology-py library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant