-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show clipped paper snapshot in fix metadata dialog #4645
Open
nschneid
wants to merge
18
commits into
master
Choose a base branch
from
dialog-snapshot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8ac5718
show clipped paper snapshot in fix metadata dialog
nschneid ef22e59
preview the new author list below the snapshot; full URL for snapshot
nschneid 6ca51f1
preview the author list on creation of the modal dialog
nschneid 9d121ea
onkeypress should be oninput
nschneid 1e74911
link to the PDF
nschneid 26641aa
elaborate correction check verbiage
nschneid f0447ef
PDF URL: not all PDFs are hosted locally
nschneid 6b42764
informative labels; drag and drop should refresh author list
nschneid 79cc62c
whitespace
nschneid b994472
author list previewing
nschneid 7e6d8e1
typo
nschneid 598b10c
string indexing
nschneid cde05c0
Try different scaling technique for paper snapshot
mbollmann 85cfa75
Merge remote-tracking branch 'origin/master' into dialog-snapshot
mjpost 9982975
Merge remote-tracking branch 'origin/master' into dialog-snapshot
mjpost f299ecd
Add trimmed thumbnail
mjpost ff1ef48
paper snapshot: fixed 100% width, trimmed snapshot
nschneid 31879d6
snapshot sizing/positioning
nschneid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around with this a bit and think something like this might work:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played quite a bit but eventually had too many hours into the project and was happy to have something working. This kind of design isn't my forte. I'll try pushing up this change on this PR.