Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Display plenary talks on event page #3603

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion bin/anthology/events.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def _create_event(self, event_id):
"year": year,
"title": f"{venue_name} ({year})",
"links": [],
"talks": [],
"volumes": [],
}

Expand All @@ -70,6 +71,8 @@ def register_event(self, event_xml):
list_elements=["url", "volume-id"],
dont_parse_elements=["meta", "links", "colocated"],
)
# parse_element does not play nicely with "talk" so add here
event_data["talk"] = event_xml.findall("talk")

# copy over on top of default values
for key, value in event_data.items():
Expand Down Expand Up @@ -107,11 +110,21 @@ def register_event(self, event_xml):
):
self.register_volume(volume_id, event_id)

elif key == "talk":
for talk in value:
parsed_talk = parse_element(talk, list_elements=["speaker"])
self.events[event_id]["talks"].append(
{
"title": parsed_talk["xml_title"].text,
"speaker": parsed_talk["speaker"],
"video": parsed_talk["video"],
}
)

else:
# all other keys
self.events[event_id][key] = value

# print(event_id, self.events[event_id])

def register_volume(self, volume: str, event_id: str):
"""
Expand Down
2 changes: 1 addition & 1 deletion bin/anthology/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ def parse_element(
"type": element.get("type", "attachment"),
"url": element.text,
}
elif tag in ("author", "editor"):
elif tag in ("author", "editor", "speaker"):
id_ = element.attrib.get("id", None)
value = (PersonName.from_element(element), id_)
elif tag == "erratum":
Expand Down
Loading