Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OpenTelemetry 0.22 #35

Merged
merged 3 commits into from
Mar 5, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Support for OpenTelemetry 0.22
abdolence committed Feb 25, 2024

Verified

This commit was signed with the committer’s verified signature.
abdolence Abdulla Abdurakhmanov
commit a4b931c790d94f371012b2ee1ed925590f854058
8 changes: 4 additions & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -22,9 +22,9 @@ path = "src/lib.rs"

[dependencies]
tracing = "0.1"
opentelemetry = { version = "0.21" }
opentelemetry_sdk = { version = "0.21", features = ["rt-tokio"] }
opentelemetry-semantic-conventions = { version = "0.13" }
opentelemetry = { version = "0.22" }
opentelemetry_sdk = { version = "0.22", features = ["rt-tokio"] }
opentelemetry-semantic-conventions = { version = "0.14" }
gcloud-sdk = { version = "0.24", features = ["google-devtools-cloudtrace-v2"] }
rvstruct = "0.3"
rsb_derive = "0.5"
@@ -36,7 +36,7 @@ async-trait = "0.1"

[dev-dependencies]
tokio = { version = "1", features = ["full"] }
opentelemetry = { version = "0.21" }
opentelemetry = { version = "0.22" }
tracing = "0.1"
tracing-subscriber = { version = "0.3", features = ["env-filter","registry"] }
tracing-opentelemetry = { version = "0.22" }
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@ opentelemetry-gcloud-trace = "0.8"

| opentelemetry-gcloud-trace version | opentelemetry version | tracing-opentelemetry | gcloud-sdk |
|------------------------------------|-----------------------|-----------------------|------------|
| 0.9 | 0.22 | 0.23 | 0.24 |
| 0.8 | 0.21 | 0.22 | 0.23 |
| 0.7 | 0.20 | 0.21 | 0.21 |
| 0.6 | 0.20 | 0.20 | 0.20 |
18 changes: 7 additions & 11 deletions src/google_trace_exporter_client.rs
Original file line number Diff line number Diff line change
@@ -140,9 +140,7 @@ impl GcpCloudTraceExporterClient {
}
}

fn convert_time_events(
events: &opentelemetry_sdk::trace::EvictedQueue<opentelemetry::trace::Event>,
) -> gspan::TimeEvents {
fn convert_time_events(events: &opentelemetry_sdk::trace::SpanEvents) -> gspan::TimeEvents {
const MAX_EVENTS: usize = 128;

gspan::TimeEvents {
@@ -151,10 +149,10 @@ impl GcpCloudTraceExporterClient {
.take(MAX_EVENTS)
.map(Self::convert_time_event)
.collect(),
dropped_annotations_count: if events.len() > MAX_EVENTS {
(events.dropped_count() as usize + events.len() - MAX_EVENTS) as i32
dropped_message_events_count: if events.len() > MAX_EVENTS {
(events.dropped_count as usize + events.len() - MAX_EVENTS) as i32
} else {
events.dropped_count() as i32
events.dropped_count as i32
},
..gspan::TimeEvents::default()
}
@@ -191,9 +189,7 @@ impl GcpCloudTraceExporterClient {
})
}

fn convert_links(
links: &opentelemetry_sdk::trace::EvictedQueue<opentelemetry::trace::Link>,
) -> gspan::Links {
fn convert_links(links: &opentelemetry_sdk::trace::SpanLinks) -> gspan::Links {
const MAX_LINKS: usize = 128;

gspan::Links {
@@ -203,9 +199,9 @@ impl GcpCloudTraceExporterClient {
.map(Self::convert_link)
.collect(),
dropped_links_count: if links.len() > MAX_LINKS {
(links.dropped_count() as usize + links.len() - MAX_LINKS) as i32
(links.dropped_count as usize + links.len() - MAX_LINKS) as i32
} else {
links.dropped_count() as i32
links.dropped_count as i32
},
..gspan::Links::default()
}