GSM L2 #449
Open
GSM L2 #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I d switch back to normal string errors, to minimize diff between GsmL2 and Gsm.
There was a problem hiding this comment.
in my ideal world, we'd use a newer solidity with custom errors to save on deployment size and gas on reverts. thought this would save on some deployment size and prepare this for the future but not a deal breaker it can be strings.
| * @dev Updates Liquidity Provider | ||
| * @param liquidityProvider The address of the liquidty provider for the GSM | ||
| */ | ||
| function _updateLiquidityProvider(address liquidityProvider) internal { |
There was a problem hiding this comment.
does it make sense to use a role for this instead?
There was a problem hiding this comment.
i was thinking only one facilitator can provide liquidity to the GSM so that's why I went with one address but don't have a strong opinion on it
ghost
reviewed
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add GSML2 implementation where GHO is provided to the GSM and then transfered in/out instead of mint/burn.
Update tests for GSML2.