Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove CIDSets from XObjects #721

Conversation

mr-mister123
Copy link
Contributor

fixes #659

do you need example-files for testing?

Greetz, Karsten

@jstaerk
Copy link
Collaborator

jstaerk commented Feb 19, 2025

Closing because for me it looks like an attempt to correct something in invalid PDF-A input files, correct? As that matter is far too complicated I would not start even trying that.

@jstaerk jstaerk closed this Feb 19, 2025
@mr-mister123
Copy link
Contributor Author

Closing because for me it looks like an attempt to correct something in invalid PDF-A input files, correct?

No, i don't think so. According to #249 you've decided to let mustang convert pdf/a-1 to pdf/a-3 and therefore removing the cid-sets from embedded fonts with commit #df83c30.

Apparently "The rules for incomplete CID sets changed between PDF/A-1a and PDF/A-3a. They are stricter in PDF/A-3a", but PDF/A-3 works completely fine without CIDsets, so the I'm now removing them.

( see )

The only thing i changed is, that your patch is not only applied to the fonts in the root-dictionary, but also to object that are embedded into the pdf (eg. when merging pdf-files). So for me it's just the consequent implementation of your built-in-support for converting pdf/a-1 to pdf/a-3.
Your original algorithm has not been changed, it's just consequently applied to all embedded fonts.

I could supply sample-files if needed.

Greetz,
Karsten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid output PDF for input with incomplete CIDsets embedded in PDXObjects
2 participants