Remove Media Foundation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSCore uses MediaFoundation API for decoding certain formats. We have been avoiding using those, because this is Windows-only and not portable.
However in some cases, CSCore might want to load them anyway for formats which we do support, which can cause issues like this: Yellow-Dog-Man/Resonite-Issues#3167
This PR completely removes all the code associated with MediaFoundation to ensure that it's not used at all.
This should be a good solution to prevent the accidental use for the time being. We do plan to move away from this library at some point (e.g. to NAudio), so at some point we will abandon our fork anyway.
The upstream doesn't update very often either, so I don't have much concern with merging changes.