Add ONNX to TOSA lowering for onnx.Tile #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TinaAMD
commented
Jan 8, 2024
TinaAMD
commented
- Lowering can only be done if the input is ranked
- The repetitions need to be constant
TinaAMD
force-pushed
the
tina.FXML-4025-onnx-to-tosa-tile
branch
from
5e60687 to
b0f6d5a
Compare
* Lowering can only be done if the input is ranked * The repetitions need to be constant
TinaAMD
force-pushed
the
tina.FXML-4025-onnx-to-tosa-tile
branch
from
b0f6d5a to
48d1678
Compare
ttjost
approved these changes
Jan 8, 2024
mgehre-amd
reviewed
Jan 8, 2024
mgehre-amd
approved these changes
Jan 8, 2024
* Use the type converter to lower to a valid tosa type * Restrict the types according to the ones the tile operator permits * Clean up matching of the constant repetitions
mgehre-amd
approved these changes
Jan 9, 2024
ttjost
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.