Merge pull request #32 from Xilinx/tiagot.align_hardswish_decomp_with…

…_torch_mlir fix: align decomposition of Hardswish with torch-mlir implementation.
Xilinx · Jan 8, 2024 · 3950d13 · 3950d13
2 parents 4357bc1 + 0ac0f51
commit 3950d13
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Transform/ONNX/Decompose.cpp b/src/Transform/ONNX/Decompose.cpp
@@ -571,7 +571,7 @@ struct DecomposeHardSwishPattern : public ConversionPattern {
         hardSwishOp.getType(), input, rewriter.getF32FloatAttr(1.0 / 6.0),
         rewriter.getF32FloatAttr(0.5));
     rewriter.replaceOpWithNewOp<ONNXMulOp>(
-        op, hardSwishOp.getType(), input, hardSigmoid);
+        op, hardSwishOp.getType(), hardSigmoid, input);
     return success();
   }
 };

diff --git a/test/mlir/onnx/onnx_decompose.mlir b/test/mlir/onnx/onnx_decompose.mlir
@@ -489,6 +489,6 @@ func.func @test_hardswish_f32(%arg0: tensor<?x?x?xf32>) -> tensor<?x?x?xf32> {
 // CHECK-LABEL:  func @test_hardswish_f32
 // CHECK-SAME:   ([[PARAM_0_:%.+]]: tensor<?x?x?xf32>) -> tensor<?x?x?xf32>
 // CHECK:           [[VAR_0_:%.+]] = "onnx.HardSigmoid"([[PARAM_0_]]) {alpha = 0.166666672 : f32, beta = 5.000000e-01 : f32} : (tensor<?x?x?xf32>) -> tensor<?x?x?xf32>
-// CHECK:           [[VAR_1_:%.+]] = "onnx.Mul"([[PARAM_0_]], [[VAR_0_]]) : (tensor<?x?x?xf32>, tensor<?x?x?xf32>) -> tensor<?x?x?xf32>
+// CHECK:           [[VAR_1_:%.+]] = "onnx.Mul"([[VAR_0_]], [[PARAM_0_]]) : (tensor<?x?x?xf32>, tensor<?x?x?xf32>) -> tensor<?x?x?xf32>
 // CHECK:           return [[VAR_1_]] : tensor<?x?x?xf32>
 }