sdl: Update submodule to 5f6d52d #713
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes XboxDev/nxdk-sdl-old#40
nxdk's SDL repository was forked from an unofficial mirror maintained on Github back when SDL was not on Github (officially)
Some years ago SDL officially migrated to Github and the SDL mirror was no longer maintained.
Unfortunately the official SDL repo had different git tree and so it was not possible for us to pull in upstream changes or rebase against upstream.
To fix this, I (painstakingly) cherry picked all of nxdk's SDL commits into the official SDL tree. I maintain author, commit author and timestamps etc so for all intents and purpose this is identical however it based off the official SDL git tree so commit hashes dont match.
This is the first step to bring up SDL to 2.3.x or SDL3
If merged, i think we should archive
XboxDev/nxdk-sdl-old
, and create a pinned issue inXboxDev/nxdk-sdl
to reference old issues. There is one open PR but no activity in 5 years. This would no longer be mergable without a rebase.Also we should change the default branch on XboxDev/nxdk-sdl to nxdk and enable issues on the fork repo