typo fixes, code clarificaiton #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 13197310612Details
💛 - Coveralls |
HenningSE
requested changes
Feb 7, 2025
There was a problem hiding this comment.
Hi @PeterGy thanks for PR fixing up some typos and improving the code of the csv example! I have just a few minor comments, basically reverting invisible changes in the jupyter notebooks to not introduce unnecessary changes.
examples/0_Getting_Started.ipynb
Outdated
There was a problem hiding this comment.
Is this new cell needed or can we revert the changes in this file?
Comment on lines
151
to
157
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [] |
There was a problem hiding this comment.
Please remove this empty cell.
examples/5_Simulation_Truth.ipynb
Outdated
There was a problem hiding this comment.
No real change here so I would propose to revert these changes.
|
@HenningSE Thanks for reviewing it so quickly. I have removed the accidental extra cell and reset all the invisible changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit this PR: make sure to put all XENONnT specific information in a wiki-note as the repo is publicly accessible
What does the code in this PR do / what does it improve?
Some typo fixes I came across in the tutorials, as well as some clarifications in the tutorial code.
Can you briefly describe how it works?
Same as before.
Can you give a minimal working example (or illustrate with a figure)?
t -> theta
Please include the following if applicable: