Add <1024 port privileges for Helm #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Looks like CI is failing. We need to fix
This one we had authorization set up but might need an update:
|
|
@eozturk1 yeah the CI is a separate issue. I'll take a look tomorrow or later today after meetings. The CI should autobump the chart version number though, we shouldn't be reliant on people autobumping ideally. |
peixian
force-pushed
the
peixian/add-port-privs
branch
from
a8f58b6 to
cddb37d
Compare
eozturk1
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ports 80, 443, and 587 are used in the config
proxy/proxy/src/proxy_config.cfg
Line 60 in 2ea2f1f
the default Helm chart will refuse to start haproxy on most Kubernetes instances out of the box. This is a known issue with #110.
For linux Kube clusters > 1.22 we can delegate it with the safe sysctl setting
net.ipv4.ip_unprivileged_port_start: https://kubernetes.io/docs/tasks/administer-cluster/sysctl-cluster/