Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong order of arguments when calling calc_quantile_loss #566

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. Fixing Incorrect CRPS calculation #554;

Before submitting

  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Feb 19, 2025

Pull Request Test Coverage Report for Build 13409339203

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.419%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/utils/metrics/error.py 1 2 50.0%
Totals Coverage Status
Change from base Build 13213866978: 0.0%
Covered Lines: 12196
Relevant Lines: 14447

💛 - Coveralls

@WenjieDu WenjieDu merged commit cb3bacc into main Feb 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants