Merge pull request #565 from c-lyu/fix/quantile-loss

Fix CRPS loss calculation
WenjieDu · Feb 19, 2025 · f5d4e24 · f5d4e24
2 parents a8d8edd + a3deb7d
commit f5d4e24
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pypots/utils/metrics/error.py b/pypots/utils/metrics/error.py
@@ -315,7 +315,7 @@ def calc_quantile_crps(
         for j in range(len(predictions)):
             q_pred.append(torch.quantile(predictions[j : j + 1], quantiles[i], dim=1))
         q_pred = torch.cat(q_pred, 0)
-        q_loss = calc_quantile_loss(targets, q_pred, quantiles[i], masks)
+        q_loss = calc_quantile_loss(q_pred, targets, quantiles[i], masks)
         CRPS += q_loss / denominator
     return CRPS.item() / len(quantiles)