🌙 Add closeVessel fees tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const treasuryBalanceAfter = await debtToken.balanceOf(treasury) | ||
|
|
||
| assert.isTrue(treasuryBalanceBefore.eq(treasuryBalanceAfter)) |
There was a problem hiding this comment.
I would prefer us to use assert.equal(A, B), so the errors will be more descriptive and better than: True is not False
There was a problem hiding this comment.
assert.equal matcher does not work on the BN type that they use
There was a problem hiding this comment.
assert.equal(before.toString(), after.toString())
nezouse
approved these changes
Apr 25, 2024
nezouse
reviewed
Apr 25, 2024
Comment on lines
211
to
227
| it('does not add fees mid epoch', async () => { | ||
| const {erc20, debtToken, borrowerOperations} = contracts.core | ||
| await openVessel(alice) | ||
| await openVessel(bob) | ||
| await skipToNextEpoch() | ||
|
|
||
| await borrowerOperations.collectVesselFee(erc20.address, alice) | ||
|
|
||
| const treasuryBalanceBefore = await debtToken.balanceOf(treasury) | ||
|
|
||
| await mintDebtTokens(alice, vesselTotalDebt) | ||
| await closeVessel(alice) | ||
|
|
||
| const treasuryBalanceAfter = await debtToken.balanceOf(treasury) | ||
|
|
||
| assert.equal(treasuryBalanceBefore.toString(), treasuryBalanceAfter.toString()) | ||
| }) |
There was a problem hiding this comment.
Will also pass after splitting treasury into treasury and distributor
nezouse
approved these changes
Apr 25, 2024
Szymx95
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.