⛏️ Split debt and redemption fees #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nezouse
force-pushed
the
split-debt-and-redemption-fees
branch
from
6c888dd to
ea30c6f
Compare
MiksuJak
requested changes
Apr 24, 2024
MiksuJak
approved these changes
Apr 25, 2024
MiksuJak
force-pushed
the
split-debt-and-redemption-fees
branch
from
2d01022 to
f18bc83
Compare
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Szymx95
reviewed
Apr 29, 2024
Comment on lines
+47
to
+55
| distributorAddress = _addresses[6]; | ||
| gasPoolAddress = _addresses[7]; | ||
| priceFeed = _addresses[8]; | ||
| sortedVessels = _addresses[9]; | ||
| stabilityPool = _addresses[10]; | ||
| timelockAddress = _addresses[11]; | ||
| treasuryAddress = _addresses[12]; | ||
| vesselManager = _addresses[13]; | ||
| vesselManagerOperations = _addresses[14]; |
There was a problem hiding this comment.
Suggested change
| distributorAddress = _addresses[6]; | |
| gasPoolAddress = _addresses[7]; | |
| priceFeed = _addresses[8]; | |
| sortedVessels = _addresses[9]; | |
| stabilityPool = _addresses[10]; | |
| timelockAddress = _addresses[11]; | |
| treasuryAddress = _addresses[12]; | |
| vesselManager = _addresses[13]; | |
| vesselManagerOperations = _addresses[14]; | |
| gasPoolAddress = _addresses[7]; | |
| priceFeed = _addresses[8]; | |
| sortedVessels = _addresses[9]; | |
| stabilityPool = _addresses[10]; | |
| timelockAddress = _addresses[11]; | |
| treasuryAddress = _addresses[12]; | |
| vesselManager = _addresses[13]; | |
| vesselManagerOperations = _addresses[14]; | |
| distributorAddress = _addresses[6]; |
Why isn't distributor address added as last in the list ?
Szymx95
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.