Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐙 Change admin default values #15

Merged
merged 7 commits into from
May 10, 2024
Merged

🐙 Change admin default values #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aad0c5c
🐙 Change mcr default
Szymx95 May 10, 2024
e113be6
Change borrowing fee
Szymx95 May 10, 2024
ad5530b
Update comments
Szymx95 May 10, 2024
acf49ce
Use mcr higher precision
Szymx95 May 10, 2024
6f2c145
Merge branch 'main' into Change_mcr_default
Szymx95 May 10, 2024
5cf9910
Update comments once again
Szymx95 May 10, 2024
44645be
Update mcr comment
Szymx95 May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/AdminContract.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ contract AdminContract is IAdminContract, UUPSUpgradeable, OwnableUpgradeable, A
uint256 public constant _100pct = 1 ether; // 1e18 == 100%
uint256 private constant DEFAULT_DECIMALS = 18;

uint256 public constant BORROWING_FEE_DEFAULT = 0.005 ether; // 0.5%
uint256 public constant BORROWING_FEE_DEFAULT = 383_561_643_835_616; // 2% * (7 / 365)
uint256 public constant CCR_DEFAULT = 0; // 0%
uint256 public constant MCR_DEFAULT = 1.1 ether; // 110%
uint256 public constant MCR_DEFAULT = 1_052_631_578_947_368_421; // 1 / 0.95
uint256 public constant MIN_NET_DEBT_DEFAULT = 2_000 ether;
uint256 public constant MINT_CAP_DEFAULT = 1_000_000 ether; // 1 million TRI
uint256 public constant REDEMPTION_FEE_FLOOR_DEFAULT = 0; // 0%
Expand Down
4 changes: 2 additions & 2 deletions test/trinity/AdminContractTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@ contract("AdminContract", async accounts => {
})

it("Formula Checks: Call every function with default value, Should match default values", async () => {
await adminContract.setBorrowingFee(ZERO_ADDRESS, (0.005e18).toString())
await adminContract.setBorrowingFee(ZERO_ADDRESS, "383561643835616")
await adminContract.setCCR(ZERO_ADDRESS, "0")
await adminContract.setMCR(ZERO_ADDRESS, "1100000000000000000")
await adminContract.setMCR(ZERO_ADDRESS, "1052631578947368421")
await adminContract.setMinNetDebt(ZERO_ADDRESS, dec(2_000, 18))
await adminContract.setMintCap(ZERO_ADDRESS, dec(1_000_000, 18))
await adminContract.setRedemptionFeeFloor(ZERO_ADDRESS, '0')
Expand Down
Loading