fix: Don't log full exceptions, some wording fixes

VoronDesign · Dec 11, 2023 · 46d8b8b · 46d8b8b
1 parent 621f36e
commit 46d8b8b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/test_pr.yml b/.github/workflows/test_pr.yml
@@ -85,6 +85,7 @@ jobs:
           args: generate-readme
       # Upload Artifact
       - uses: actions/upload-artifact@65d862660abb392b8c4a3d1195a2108db131dd05
+        if: '!cancelled()'
         with:
           name: ci_output
           path: workflow_output
diff --git a/voron_ci/tools/stl_corruption_checker.py b/voron_ci/tools/stl_corruption_checker.py
@@ -39,11 +39,11 @@ def run(self: Self) -> None:
 
         self.gh_helper.finalize_action(
             action_result=ActionResult(
-                action_id="stl_corruption_checker",
-                action_name="STL Corruption Checker",
+                action_id="corruption_checker",
+                action_name="STL corruption checker",
                 outcome=self.return_status,
                 summary=ActionSummaryTable(
-                    title="STL Corruption Checker",
+                    title="STL corruption checker",
                     columns=["Filename", "Result", "Edges Fixed", "Backwards Edges", "Degenerate Facets", "Facets Removed", "Facets Added", "Facets Reversed"],
                     rows=self.check_summary,
                 ),
@@ -88,7 +88,7 @@ def _check_stl(self: Self, stl_file_path: Path) -> ReturnStatus:
             logger.success("STL '{}' OK!", stl_file_path.relative_to(self.input_dir).as_posix())
             return ReturnStatus.SUCCESS
         except Exception:  # noqa: BLE001
-            logger.exception("A fatal error occurred while checking '{}'!", stl_file_path.relative_to(self.input_dir).as_posix())
+            logger.critical("A fatal error occurred while checking '{}'!", stl_file_path.relative_to(self.input_dir).as_posix())
             self.check_summary.append(
                 [stl_file_path.name, SummaryStatus.EXCEPTION, "0", "0", "0", "0", "0", "0"],
             )

diff --git a/voron_ci/tools/stl_rotation_checker.py b/voron_ci/tools/stl_rotation_checker.py
@@ -165,8 +165,8 @@ def _check_stl(self: Self, stl_file_path: Path) -> ReturnStatus:
 
             logger.success("File '{}' OK!", stl_file_path.relative_to(self.input_dir).as_posix())
             return ReturnStatus.SUCCESS
-        except Exception as e:  # noqa: BLE001
-            logger.exception("A fatal error occurred during rotation checking", exc_info=e)
+        except Exception:  # noqa: BLE001
+            logger.critical("A fatal error occurred while checking {}", stl_file_path.relative_to(self.input_dir).as_posix())
             self.check_summary.append([stl_file_path.name, SummaryStatus.EXCEPTION, "", ""])
             return ReturnStatus.EXCEPTION