Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ P256 s normalized #1363

Merged
merged 4 commits into from
Feb 24, 2025
Merged

✨ P256 s normalized #1363

merged 4 commits into from
Feb 24, 2025

Conversation

Vectorized
Copy link
Owner

Description

Makes it easier to work with.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Copy link

github-actions bot commented Feb 24, 2025

Gas Snapshot Comparison Report

Generated at commit : bcb5a1b, Compared to commit : dcf23b8

Contract Name Test Name Main Gas PR Gas Diff
P256Test testP256VerifyNonMalleableRIPPrecompile() 337044 337067 23
testP256VerifyOutOfBounds() 201616 201594 -22
testP256VerifyWycheproof() 3202 3225 23
test__codesize() 12271 13147 876

@Vectorized
Copy link
Owner Author

I think i'll keep the mallaebility check. Just in case some dev wanna use secp256r1 signatures for poor-mans-VRF.

@Vectorized Vectorized merged commit 83ea466 into main Feb 24, 2025
13 checks passed
@Vectorized Vectorized deleted the p256-normalize-s branch February 24, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant