Prohibit call array_diff for arrays that have shapes and tuples inside
#1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkornaukhov03
requested review from
Danil42Russia,
apolyakov and
astrophysik
apolyakov
approved these changes
Feb 28, 2025
mkornaukhov03
deleted the
mkornaukhov03/prohibit-array-diff-for-tuples
branch
Danil42Russia
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it leads to error in g++ stage. For now it will be caught in transpilation stage.
Note
In reality, it's possible to implement array_diff for shapes and tuples. To solve this we should use hash set (choose appropriate allocator!) instead of
array resutinarray_diff_impl(). Do not use justhash()instead of projection because it should be injective function.