Add variables for remaining individual matching #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgreenbury
commented
Feb 21, 2025
| return get_test_dfs_and_mapping(mapping_ind) | ||
|
|
||
|
|
||
| def combine_dfs_with_matches(df1, df2, matches_dict) -> pd.DataFrame: |
There was a problem hiding this comment.
As discussed, might be helpful to move this function into library for use in the matching script directly when applying matches_ind
sgreenbury
commented
Feb 21, 2025
| def test_match_psm(): | ||
| pass | ||
| @pytest.fixture | ||
| def ind_hh(): |
There was a problem hiding this comment.
Might be helpful to add a comment explaining these fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85.
This PR:
match_psmto select matching columns that start with the given column namesRemaining tasks: