-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise travel day and region variable #90
base: main
Are you sure you want to change the base?
Conversation
7d5600c
to
fcc9a57
Compare
- Revise get_chosen_day api - Add tests for get_chosen_day - Simplify model for non-common household travel day
activities_to_assign=possible_zones_work, actual_flows=travel_demand_dict_nomode | ||
activities_to_assign=possible_zones_work, | ||
actual_flows=travel_demand_dict_nomode, | ||
scaling=config.parameters.part_time_work_prob, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently config of scaling of the flows is implemented through the part_time_work_prob
. The name of this parameter should be revised - however, this will change the ID of the config so it would be preferred to update the name in a subsequent PR once the current parameter testing is complete.
488ed44
to
9412aa2
Compare
9412aa2
to
9df20d9
Compare
@sgreenbury does the config.toml need to use the new regions in the nts_regions variable? |
Yes this should be updated to the new set of regions included in "PSUStatsReg_B01ID". Validating this when the config is parsed might be helpful too, e.g.: Line 57 in 9fe4170
I'll add this. |
] | ||
# nts day of the week to use | ||
# 1: Monday, 2: Tuesday, 3: Wednesday, 4: Thursday, 5: Friday, 6: Saturday, 7: Sunday | ||
nts_day_of_week = 3 | ||
nts_days_of_week = [3] | ||
# what crs do we want the output to be in? (just add the number, e.g. 3857) | ||
output_crs = 3857 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the new parameters to the base.toml
as being used to document config. In particular, more on common_household_day: bool = True
for case when true
and false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add part_time_work_prob
and a description of what the parameter does and also the effect when use_percentages = false/true
As discussed with @Hussein-Mahfouz, as well as changes above, also check the determinism for a given seed (move to new issue). |
Closes #86.
This PR continues from closed #82 rebased on main with new branch name.
This PR:
nts_days_of_week
chosen_day
randomly picked during feasible zone assignmentpart_time_work_prob
parameter (see below). The related census question 49 ("Where do you mainly work?") suggests that on a randomly chosen work day an individual would not necessarily be commuting. A float for scaling can be applied to the flows applicable ifuse_percentages=False
(see Discrepancy in no. of work trips: census vs nts/acbm #86 (comment) for additional discussion)"PSUStatsReg_B01ID"
as this is included for 2021 and 2022Remaining tasks:
h - w -h
chains in the validation script