Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts and notebook for validation stats and plots #84

Open
wants to merge 20 commits into
base: 86-revise-trav-day
Choose a base branch
from

Conversation

sgreenbury
Copy link
Collaborator

Contributes towards #17.

This PR adds a script to print validation stats (including $R^2$ correlation with census commuting flows) for a given config ID.

Base automatically changed from 53-paths to main January 30, 2025 18:06
@sgreenbury sgreenbury force-pushed the 17-validation-stats-script branch from f6069a7 to e486a73 Compare January 31, 2025 15:58
@sgreenbury sgreenbury changed the base branch from main to 86-revise-trav-day January 31, 2025 16:28
@sgreenbury sgreenbury force-pushed the 17-validation-stats-script branch from e486a73 to 287811a Compare January 31, 2025 16:29
@sgreenbury sgreenbury changed the title Add validation stats script Add scripts and notebook for validation stats and plots Jan 31, 2025
@sgreenbury sgreenbury force-pushed the 17-validation-stats-script branch from 2c9583f to e705a0b Compare February 4, 2025 17:48
Comment on lines +114 to +115
# Work From Home (1) and Travel to work (3)
# .filter(pl.col("Place of work indicator (4 categories) code").is_in([1, 3]))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove as no longer considering 1 and 3

)
def main(config_file_stem: str | None, include_wfh: bool):
records = []
for i, config_file in enumerate(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be helpful to raise an error if path or filepath stem is passed incorrectly.

)

for _i, (origin, sub) in enumerate(gdf.groupby("ozone")):
# fig, axs = plt.subplots(1, 3, figsize=(20, 16))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

default=False,
)
@click.option("--scaling", type=float, default=1.0, required=False)
def main(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add examples of calling the CLI to the scripts README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant