CDD-2442 Set Up CI/CD Workflow for auth-dev and auth-test Environments #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unit test coverage report
|
ChristianAMartin
force-pushed
the
task/configure-cicd-pipeline/CDD-2442
branch
2 times, most recently
from
8b44df5 to
ca48516
Compare
ChristianAMartin
force-pushed
the
task/configure-cicd-pipeline/CDD-2442
branch
2 times, most recently
from
59be983 to
8572079
Compare
A-Ashiq
reviewed
Feb 19, 2025
A-Ashiq
reviewed
Feb 19, 2025
A-Ashiq
reviewed
Feb 19, 2025
A-Ashiq
reviewed
Feb 19, 2025
A-Ashiq
reviewed
Feb 19, 2025
.github/workflows/pull-request.yml
Outdated
| - name: Set AWS Role for Target Environment | ||
| env: | ||
| TARGET_ENV: ${{ needs.build_base.outputs.target_env || 'test' }} | ||
| AWS_ROLE_AUTH_DEV: ${{ secrets.UHD_TERRAFORM_ROLE_AUTH_DEV }} |
There was a problem hiding this comment.
Can you remove this please, we shouldn't be touching the dev account from the PR workflow
A-Ashiq
reviewed
Feb 19, 2025
.github/workflows/pull-request.yml
Outdated
| AWS_ROLE_TEST: ${{ secrets.UHD_TERRAFORM_ROLE_TEST }} | ||
| run: | | ||
| if [[ "$TARGET_ENV" == "auth-dev" ]]; then | ||
| echo "AWS_ROLE=$AWS_ROLE_AUTH_DEV" >> $GITHUB_ENV |
There was a problem hiding this comment.
As above, we should only be interacting with either of the test accounts from the PR workflow
A-Ashiq
reviewed
Feb 19, 2025
| @@ -149,6 +149,8 @@ jobs: | |||
| dev-account-role: ${{ secrets.UHD_TERRAFORM_ROLE_DEV }} | |||
| test-account-role: ${{ secrets.UHD_TERRAFORM_ROLE_TEST }} | |||
| uat-account-role: ${{ secrets.UHD_TERRAFORM_ROLE_UAT }} | |||
| auth-dev-account-role: ${{ secrets.UHD_TERRAFORM_ROLE_AUTH_DEV }} | |||
There was a problem hiding this comment.
I suspect that these roles won't exist yet, so we've got the chicken & egg situation I was talking about before.
I think we'll likely need to deploy to those envs from our machines the first time around, and then we can pass in the role ARN to these secrets
A-Ashiq
reviewed
Feb 19, 2025
| fi | ||
|
|
||
| if [[ $workspace == *"auth"* ]]; then | ||
| _get_auth_target_aws_account_name "$workspace" |
A-Ashiq
reviewed
Feb 19, 2025
| fi | ||
| } | ||
|
|
||
| function _get_auth_target_aws_account_name() { | ||
| local workspace=$1 | ||
|
|
There was a problem hiding this comment.
We'll need a case to handle the ephemeral CI environments too being matched to the auth-test account
ChristianAMartin
force-pushed
the
task/configure-cicd-pipeline/CDD-2442
branch
from
df28a70 to
042d250
Compare
ChristianAMartin
force-pushed
the
task/configure-cicd-pipeline/CDD-2442
branch
from
d856dde to
ccc4f1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to set up and integrate the CI/CD pipeline for the newly provisioned auth-dev and auth-test AWS accounts. This involves ensuring the infrastructure deployment process is automated and aligned with existing workflows for other environments.