Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "CDD-2230: Started to abstract out the components from… #581

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

luketowell
Copy link
Contributor

… within the View…""

This reverts commit ea1a649.

Description

Removal of the following components into their own components so that the View structure is more composable.

Fixes #CDD-2230

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Playwright e2e tests
  • Mobile responsiveness
  • Accessibility (i.e. Lighthouse audit)
  • Disabled JavaScript

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any styles in this change follow the 'STYLES.md' guide
  • My changes are progressively enhanced with graceful degradation for older browsers and non-JavaScript users
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@luketowell luketowell requested a review from a team as a code owner January 27, 2025 15:51
Copy link

github-actions bot commented Jan 27, 2025

Unit tests coverage

Lines Statements Branches Functions
Coverage: 96%
94.65% (1930/2039) 85.08% (485/570) 94.57% (314/332)
Tests Skipped Failures Errors Time
563 0 💤 0 ❌ 0 🔥 17.779s ⏱️

Copy link

@luketowell luketowell merged commit 646ca82 into main Feb 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants