Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Field type - DateField #572

Merged
merged 18 commits into from
Feb 6, 2025

Conversation

Temiakinsoto
Copy link
Contributor

@Temiakinsoto Temiakinsoto commented Jan 22, 2025

Description

This change adds a new input field for the dashboard feedback page. In this PR, a new feedback page additional fieldtype component and unit tests were added for the feedback page.

Fixes #CDD-2349

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Playwright e2e tests
  • Mobile responsiveness
  • Accessibility (i.e. Lighthouse audit)
  • Disabled JavaScript

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any styles in this change follow the 'STYLES.md' guide
  • My changes are progressively enhanced with graceful degredagation for older browsers and non-JavaScript users
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Temiakinsoto Temiakinsoto requested a review from a team as a code owner January 22, 2025 10:00
Copy link

github-actions bot commented Jan 22, 2025

Unit tests coverage

Lines Statements Branches Functions
Coverage: 96%
94.58% (1904/2013) 85.08% (485/570) 94.46% (307/325)
Tests Skipped Failures Errors Time
556 0 💤 0 ❌ 0 🔥 16.155s ⏱️

Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link
Contributor

@luketowell luketowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Temi 👍

@Temiakinsoto Temiakinsoto merged commit 06257f5 into main Feb 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants