-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Field type - DateField #572
Merged
Temiakinsoto
merged 18 commits into
main
from
feat/CDD-2349-feedback-additional-fieldtypes2
Feb 6, 2025
Merged
Additional Field type - DateField #572
Temiakinsoto
merged 18 commits into
main
from
feat/CDD-2349-feedback-additional-fieldtypes2
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit adds hidden input state for validation This slice of state is updated when all date fields(day,month,year) are filled. The updated state is then sent as the form value for cleanName: enter_a_memorable_date
luketowell
reviewed
Feb 6, 2025
luketowell
reviewed
Feb 6, 2025
…://github.com/UKHSA-Internal/data-dashboard-frontend into feat/CDD-2349-feedback-additional-fieldtypes2
|
luketowell
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Temi 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new input field for the dashboard feedback page. In this PR, a new feedback page additional fieldtype component and unit tests were added for the feedback page.
Fixes #CDD-2349
Type of change
How Has This Been Tested?
Checklist: