Merge pull request #550 from UKHSA-Internal/bug/feedback-page-validation

Title-case enum values for yes/no question
UKHSA-Internal · Nov 19, 2024 · 5606875 · 5606875 · github-actions · Nov 19, 2024
2 parents 34aecc4 + e1ab284
commit 5606875
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/api/requests/suggestions/postSuggestions.spec.ts b/src/api/requests/suggestions/postSuggestions.spec.ts
@@ -9,7 +9,7 @@ test('Handles successful submission from the api', async () => {
 
   const { success } = await postSuggestions({
     what_was_your_reason_for_visiting_the_dashboard_today: '',
-    did_you_find_everything_you_were_looking_for: 'yes',
+    did_you_find_everything_you_were_looking_for: 'Yes',
     how_could_we_improve_your_experience_with_the_dashboard: '',
     what_would_you_like_to_see_on_the_dashboard_in_the_future: '',
   })

diff --git a/src/schemas/feedback.schema.ts b/src/schemas/feedback.schema.ts
@@ -3,7 +3,7 @@ import * as z from 'zod'
 export const feedbackSchema = z
   .object({
     what_was_your_reason_for_visiting_the_dashboard_today: z.string().optional().nullable(),
-    did_you_find_everything_you_were_looking_for: z.enum(['yes', 'no']).or(z.undefined()),
+    did_you_find_everything_you_were_looking_for: z.enum(['Yes', 'No']).or(z.undefined()),
     how_could_we_improve_your_experience_with_the_dashboard: z.string().optional().nullable(),
     what_would_you_like_to_see_on_the_dashboard_in_the_future: z.string().optional().nullable(),
   })