-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GET song endpoint #18
Open
aparnahrn
wants to merge
14
commits into
main
Choose a base branch
from
upgradeNodeVersion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove use of Link and a tag
darren2hang
previously requested changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple comments on deleting some extra stuff.
Can you rename the pull request to feat: add GET song endpoint
?
For the pull request description, can you include a brief description about what you added and on how to test. Can you also add closes: #6
in the description?
Co-authored-by: Darren Zhang <56695604+darren2hang@users.noreply.github.com>
Co-authored-by: Darren Zhang <56695604+darren2hang@users.noreply.github.com>
Co-authored-by: Darren Zhang <56695604+darren2hang@users.noreply.github.com>
Co-authored-by: Darren Zhang <56695604+darren2hang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a feature to get a particular song that we are looking from from an array of all of the songs. To test it, we used postman to ensure that the request sends properly to the server and we were able to get the songs that were needed.
closes: #6