Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GET song endpoint #18

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: add GET song endpoint #18

wants to merge 14 commits into from

Conversation

aparnahrn
Copy link

@aparnahrn aparnahrn commented Apr 25, 2023

Added a feature to get a particular song that we are looking from from an array of all of the songs. To test it, we used postman to ensure that the request sends properly to the server and we were able to get the songs that were needed.

closes: #6

Copy link
Contributor

@darren2hang darren2hang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple comments on deleting some extra stuff.
Can you rename the pull request to feat: add GET song endpoint?
For the pull request description, can you include a brief description about what you added and on how to test. Can you also add closes: #6 in the description?

@aparnahrn aparnahrn changed the title Upgrade node version add GET song endpoint May 17, 2023
Co-authored-by: Darren Zhang <56695604+darren2hang@users.noreply.github.com>
@mergify mergify bot dismissed darren2hang’s stale review May 17, 2023 04:13

Pull request has been modified.

aparnahrn and others added 3 commits May 16, 2023 21:14
Co-authored-by: Darren Zhang <56695604+darren2hang@users.noreply.github.com>
Co-authored-by: Darren Zhang <56695604+darren2hang@users.noreply.github.com>
Co-authored-by: Darren Zhang <56695604+darren2hang@users.noreply.github.com>
@aparnahrn aparnahrn requested a review from darren2hang May 17, 2023 04:16
@aparnahrn aparnahrn changed the title add GET song endpoint feat: add GET song endpoint May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: add GET songs endpoint
2 participants