Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #66

Merged
merged 53 commits into from
Aug 27, 2024
Merged

Tests #66

merged 53 commits into from
Aug 27, 2024

Conversation

halentin
Copy link
Contributor

  • add Tests for FMI2

  • Tests missing for fmi2<Set, Get><Boolean, String> because the FMU used for testing doesnt have such variables

  • Some Calls throw fmi2StatusWarning because the FMU used for testing doenst have variables with causality=<input, output>

  • Typos in src/FMI2/cfunc.jl

@halentin
Copy link
Contributor Author

  • Added Tests for fmi2<Set, Get><Boolean, String> using the IO.fmu from FMIZoo.jl

  • Those Tests should pass on all Combinations from the Matrix

  • There is a weird bug with fmi2DoStep present that appears with both 32-Bit FMUs:

[Warning][][test_cs]: fmi2DoStep: currentCommunicationPoint = 5.37764e-19, expected last stop time at 0.0078125,
 this indicates a mismatch in the master. Simulation will try to continue.

even though SetupExperiment is called with startTime = 0.0 right before. I suspect it is a Problem with Dymola 32-Bit FMUs
This sometimes leads to failing Tests (only on Julia 1.6 for some reason).
I patched it by not testing fmi2DoStep on 32-Bit Systems, but will have to be investigated further to make 32-Bit CoSimulation FMUs work.

@@ -4,15 +4,6 @@
#
using ZipFile

function test_status_ok(status)
@test typeof(status) == fmi2Status
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type checks are not necessary (redundant), because we will check for type stable functions in the next release

@ThummeTo ThummeTo changed the base branch from v1.0.2 to main August 26, 2024 13:27
@ThummeTo
Copy link
Owner

  • Added Tests for fmi2<Set, Get><Boolean, String> using the IO.fmu from FMIZoo.jl

    • Those Tests should pass on all Combinations from the Matrix

    • There is a weird bug with fmi2DoStep present that appears with both 32-Bit FMUs:

[Warning][][test_cs]: fmi2DoStep: currentCommunicationPoint = 5.37764e-19, expected last stop time at 0.0078125,
 this indicates a mismatch in the master. Simulation will try to continue.

even though SetupExperiment is called with startTime = 0.0 right before. I suspect it is a Problem with Dymola 32-Bit FMUs This sometimes leads to failing Tests (only on Julia 1.6 for some reason). I patched it by not testing fmi2DoStep on 32-Bit Systems, but will have to be investigated further to make 32-Bit CoSimulation FMUs work.

no problem, 1.6 will be replace by 1.10 as LTS very soon anyway

@ThummeTo ThummeTo merged commit f07407f into ThummeTo:main Aug 27, 2024
11 of 12 checks passed
@halentin halentin deleted the tests branch September 17, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants