Adds collection subscriptions. (PP-1875) #2287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2287 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 362 362
Lines 41368 41410 +42
Branches 8865 8878 +13
=======================================
+ Hits 37696 37735 +39
Misses 2406 2406
- Partials 1266 1269 +3 ☔ View full report in Codecov by Sentry. |
jonathangreen
approved these changes
Feb 24, 2025
Comment on lines
+651
to
+661
| @staticmethod | ||
| def make_collection_inactive(collection: Collection): | ||
| """Make a collection inactive using some settings that will make it so.""" | ||
| collection.integration_configuration.settings_dict.update( | ||
| { | ||
| "subscription_activation_date": datetime.date(2000, 12, 31), | ||
| "subscription_expiration_date": datetime.date(1999, 1, 1), | ||
| } | ||
| ) | ||
| flag_modified(collection.integration_configuration, "settings_dict") | ||
| assert not collection.is_active |
There was a problem hiding this comment.
Minor: Might be nice to use the methods on the integration to make this settings change, since it does a little more validation.
Suggested change
| @staticmethod | |
| def make_collection_inactive(collection: Collection): | |
| """Make a collection inactive using some settings that will make it so.""" | |
| collection.integration_configuration.settings_dict.update( | |
| { | |
| "subscription_activation_date": datetime.date(2000, 12, 31), | |
| "subscription_expiration_date": datetime.date(1999, 1, 1), | |
| } | |
| ) | |
| flag_modified(collection.integration_configuration, "settings_dict") | |
| assert not collection.is_active | |
| def make_collection_inactive(self, collection: Collection) -> None: | |
| """Make a collection inactive using some settings that will make it so.""" | |
| protocol_cls = self._goal_registry_mapping[Goals.LICENSE_GOAL][collection.protocol] | |
| protocol_cls.settings_update( | |
| collection.integration_configuration, | |
| { | |
| "subscription_activation_date": datetime.date(2000, 12, 31), | |
| "subscription_expiration_date": datetime.date(1999, 1, 1), | |
| }, | |
| merge=True | |
| ) | |
| assert not collection.is_active |
| ) -> None: | ||
| [c1] = db.default_library().associated_collections | ||
| default_library = db.library(short_name="default", name="Default Library") |
There was a problem hiding this comment.
Minor: This could be kind of confusing. I tend to assume the "default library" is what comes back from db.default_library(). Might be helpful to either:
- Just use
db.default_library() - use
db.library()but rename the variable so its not calleddefault_library
| sync_task.apply_async.assert_any_call( | ||
| (library.id, patron.id, loan_fixture.valid_credentials["password"]), | ||
| (collection.id, patron.id, loan_fixture.valid_credentials["password"]), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds implementation for collection subscriptions.
Motivation and Context
Allow collections to become active or inactive on a schedule. (This is an addition to the existing ability to add/delete collection in real-time via the Admin UI.)
[Jira PP-1875]
How Has This Been Tested?
Checklist