- Ensure countdown values never go below zero in the modal logic for …

…API request timeouts. - Update visit classifications to skip "false-trigger" and reclassify "none" as "unidentified" to simplify activity digest emails.
TheCacophonyProject · Feb 11, 2025 · 029f8cf · 029f8cf
1 parent 9712500
commit 029f8cf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/api/scripts/project-activity-digest.ts b/api/scripts/project-activity-digest.ts
@@ -130,6 +130,12 @@ const allVisitsForProjectInTimespan = async (
     }
     if (!alreadySentNoActivityEmail) {
       for (const visit of visits) {
+        if (visit.classification === "false-trigger") {
+          continue;
+        }
+        if (visit.classification === "none") {
+          visit.classification = "unidentified";
+        }
         recordingData[visit.classification] =
           recordingData[visit.classification] || 0;
         recordingData[visit.classification] += 1;

diff --git a/browse-next/src/components/NetworkConnectionAlertModal.vue b/browse-next/src/components/NetworkConnectionAlertModal.vue
@@ -41,9 +41,9 @@ watch(
     if (networkConnectionError.retryCount === MAX_RETRY_COUNT) {
       show.value = false;
     } else {
-      countDown.value = count / 1000;
+      countDown.value = Math.max(0, count / 1000);
       countDownInterval.value = setInterval(() => {
-        countDown.value--;
+        countDown.value = Math.max(0, countDown.value - 1);
       }, 1000) as unknown as number;
     }
   },