Update Microsoft.IO.RecyclableStreams to v3 #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce to FSharp.Control.WebSockets?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Fixes #9. There were no code changes, it just needed to be recompiled with the new package version. The failure was due to them changing the return type of a method from
MemoryStream
toRecyclableMemoryStream
, so the method wasn't found at runtime, but that didn't need anything to change in the code.Paket added a bunch of other unrelated changes. At work, we typically just ignore those other changes. Would you prefer they were reverted?