Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TKSS-670: Remove TLCPServerHello #671

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

johnshajiang
Copy link
Collaborator

TLCPServerHello is redundant and it should use ServerHello on TLS 1.2 instead.

This PR will resolves #670.

@johnshajiang johnshajiang added the cleanup Cleanup on codes label Feb 5, 2024
@johnshajiang johnshajiang self-assigned this Feb 5, 2024
@johnshajiang johnshajiang merged commit f27848a into Tencent:master Feb 5, 2024
9 checks passed
@johnshajiang johnshajiang deleted the TKSS-670 branch February 5, 2024 07:27
@Yifei0727
Copy link

国标38636 /国密0024 里server hello消息没有 session ticket的支持。 复用现有tls1.3的扩展实现,这会导致在于某些(doge)特定的tlcp实现者对接检测时出现异常终止(这些检测软件不支持、不忽略这个扩展) 。
虽然正常是能与现有多数国密浏览器等对接,从理论上这个错误应当被客户端(检测软件)忽略/支持,但实际上使用者遇到此问题时将会很头疼。备注下 供后来者参考避免重复掉坑。

@johnshajiang
Copy link
Collaborator Author

@Yifei0727
我建议你开一个issue,将上述问题放在那里面。
我们可以在这个新issue里面作进一步讨论。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup on codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TLCPServerHello
2 participants