Bugfix/android fullscreen layout #495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kot331107 perhaps best if I wait with this PR until after your rework on reparenting has landed? |
yeah, would be great, thank you. Also I'm gonna test these changes as a patch in our apps |
|
@tvanlaerhoven looks good on our apps with my latest reparenting patch 👍 I have tested on both api 34 and 35. edge 2 edge is enabled in these apps by design. |
kot331107
reviewed
Feb 18, 2025
| @@ -240,9 +250,13 @@ class PresentationManager( | |||
| ) | |||
| updatePresentationMode(PresentationMode.INLINE) | |||
|
|
|||
| // Remove forced layout observer | |||
| fullScreenLayoutObserver.remove(reactPlayerGroup) | |||
There was a problem hiding this comment.
wdyt to unsubscribe in destroy() function as well @tvanlaerhoven ?
tvanlaerhoven
force-pushed
the
bugfix/android-fullscreen-layout
branch
from
0a8e6e4 to
1aa6558
Compare
…View among the direct parents
tvanlaerhoven
force-pushed
the
bugfix/android-fullscreen-layout
branch
from
3e08d2d to
b02e347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fullscreen behaviour needs some changes on Android
Dimensiondid not suffice. We now ask the rootView's usable screen dimensions.{top:0, left:0}, ignoring any translation the React Native lay-out engine (specifically NewArch's Yoga engine) imposes.THEOplayer_reparent_on_fullscreen=false.