Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vue #8

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open

Feat/vue #8

wants to merge 30 commits into from

Conversation

liweijie0812
Copy link
Member

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR implements support for the tdesign-vue repository by adding a new GitHub Actions workflow and updating git and trigger utilities to handle Vue‐specific PR processes. Key changes include:

  • Introducing a new workflow (.github/workflows/test-tdesign-vue.yaml) for pull requests targeting develop.
  • Renaming and updating the git configuration function and adding new SSH configuration logic.
  • Extending trigger and git utility functions to accommodate repository-specific operations and fork PR handling.

Reviewed Changes

File Description
.github/workflows/test-tdesign-vue.yaml Adds a workflow to test tdesign-vue PRs
src/utils.ts Renames git config function to setGitGlobalConfig and adds SSH config
src/utils/trigger.ts Updates import and switch-case mappings for trigger context handling
src/utils/git.ts Adds helper functions for branch checkout, PR checkout, and remote setup
action.yml Updates token input description and makes it required
src/index.ts Updates the entry point to use the new git config function
src/tdesign/vue.ts Introduces Vue-specific update logic for handling PR operations

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

mkdirSync(`${sshPath}`, { mode: 0o700 })
writeFileSync(`${sshPath}/id_rsa`, token, { mode: 0o600 })
await exec('ls', ['-al', sshPath])
await exec(`ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts`)
Copy link
Preview

Copilot AI Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using shell redirection (>>) in exec may not work as expected since exec does not spawn a shell by default. Consider using a shell wrapper (e.g., exec('sh', ['-c', 'ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts'])) or handling output redirection explicitly.

Suggested change
await exec(`ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts`)
await exec('sh', ['-c', 'ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts'])

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant