Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor: Reorganize someday hooks #265

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

tyler-dane
Copy link
Contributor

@tyler-dane tyler-dane commented Feb 19, 2025

This is a follow-up PR for #264 and a companion for #255

Once this is merged, it'll also make fixing #252 a lot easier

@tyler-dane tyler-dane linked an issue Feb 19, 2025 that may be closed by this pull request
Going to do this in the sidebar for now for simplicity
currently opening the correct form when clicking an existing draft

need to update for new drafts (and shortcuts)
need to update for new drafts (and shortcuts)
the placement value is currently correct, but the form is still visually appearing in the wrong location. this is likely due to how the refs are handled
@tyler-dane tyler-dane force-pushed the fix/252-someday-clicks branch from 66d7cd1 to 9a55cc0 Compare February 25, 2025 12:23
Replaced direct plugin usage in eslint config with plugin object.

The flat config system expects each item in the array to be a valid configuration object
Plugins need to be explicitly registered in the plugins field
@tyler-dane tyler-dane changed the title 🐛 Fix: open someday event after clicking placeholder ♻️ Refactor: Convert someday state to hooks Feb 25, 2025
@tyler-dane tyler-dane changed the title ♻️ Refactor: Convert someday state to hooks ♻️ Refactor: Reorganize someday hooks Feb 25, 2025
@tyler-dane tyler-dane linked an issue Feb 25, 2025 that may be closed by this pull request
2 tasks
@tyler-dane tyler-dane marked this pull request as ready for review February 25, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple clicks required to create new Someday event Refactor draft hooks
1 participant