fix: fix prometheus formatter for non-string data point labels

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
SumoLogic · Jan 18, 2024 · 8e41b8a · 8e41b8a
1 parent e35d054
commit 8e41b8a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/pkg/exporter/sumologicexporter/prometheus_formatter.go b/pkg/exporter/sumologicexporter/prometheus_formatter.go
@@ -68,7 +68,7 @@ func (f *prometheusFormatter) tags2String(attr pcommon.Map, labels pcommon.Map)
 
 	attr.CopyTo(mergedAttributes)
 	labels.Range(func(k string, v pcommon.Value) bool {
-		mergedAttributes.PutStr(k, v.Str())
+		mergedAttributes.PutStr(k, v.AsString())
 		return true
 	})
 	length := mergedAttributes.Len()

diff --git a/pkg/exporter/sumologicexporter/prometheus_formatter_test.go b/pkg/exporter/sumologicexporter/prometheus_formatter_test.go
@@ -57,10 +57,16 @@ func TestTags2String(t *testing.T) {
 	require.NoError(t, err)
 
 	_, attributes := exampleIntMetric()
+	attributes.PutInt("int", 200)
+
+	labels := pcommon.NewMap()
+	labels.PutInt("l_int", 200)
+	labels.PutStr("l_str", "two")
+
 	assert.Equal(
 		t,
-		prometheusTags(`{test="test_value",test2="second_value"}`),
-		f.tags2String(attributes, pcommon.NewMap()),
+		prometheusTags(`{test="test_value",test2="second_value",int="200",l_int="200",l_str="two"}`),
+		f.tags2String(attributes, labels),
 	)
 }