Skip to content

Commit

Permalink
chore: investigate ecr login issue
Browse files Browse the repository at this point in the history
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
  • Loading branch information
Dominik Rosiek committed Feb 28, 2024
1 parent 7b8eede commit 1a16b2c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/dev_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,8 @@ jobs:
build-windows-container-images:
name: Build Windows container
runs-on: windows-2022
needs:
- build
# needs:
# - build
strategy:
matrix:
arch_os: [ 'windows_amd64']
Expand All @@ -211,7 +211,11 @@ jobs:
run: echo "Running dev build for ${{ steps.extract_tag.outputs.tag }}"

- name: Login to Open Source ECR
run: make login
run: |
ls -al "C:\\Program Files\\"
ls -al "C:\\Users\\"
cat "C:\\Users\\Git\\.docker\\config.json"
make login
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID_DEV }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY_DEV }}
Expand Down
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,8 @@ build-push-container-multiplatform-dev: REPO_URL = "$(OPENSOURCE_REPO_URL_DEV)"
build-push-container-multiplatform-dev: build-push-container-multiplatform

.PHONY: build-push-container-windows-dev
build-push-container-multiplatform-dev: DOCKERFILE = Dockerfile_windows
build-push-container-multiplatform-dev: build-push-container-multiplatform-dev
build-push-container-windows-dev: DOCKERFILE = Dockerfile_windows
build-push-container-windows-dev: build-push-container-multiplatform-dev

.PHONY: push-container-manifest-dev
push-container-manifest-dev: REPO_URL = "$(OPENSOURCE_REPO_URL_DEV)"
Expand All @@ -308,8 +308,8 @@ _build-container-multiplatform:
build-container-multiplatform: _build-container-multiplatform

.PHONY: build-container-windows
build-push-container-windows: DOCKERFILE = Dockerfile_windows
build-container-multiplatform: _build-container-multiplatform
build-container-windows: DOCKERFILE = Dockerfile_windows
build-container-windows: _build-container-multiplatform

.PHONY: build-push-container-windows
build-push-container-windows: PUSH = --push
Expand Down

0 comments on commit 1a16b2c

Please sign in to comment.