Merge pull request #80 from SumoLogic/sign-windows

Add windows binary signing CI stage
SumoLogic · May 6, 2024 · a31123a · a31123a
2 parents d4bcb97 + c61ae97
commit a31123a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/.github/workflows/_reusable_build_package.yml b/.github/workflows/_reusable_build_package.yml
@@ -43,6 +43,16 @@ on:
         required: false
       productbuild_identity_name:
         required: false
+      microsoft_certificate:
+        required: false
+      microsoft_certificate_password:
+        required: false
+      microsoft_certhash:
+        required: false
+      microsoft_certname:
+        required: false
+      microsoft_description:
+        required: false
 
 defaults:
   run:
@@ -290,6 +300,15 @@ jobs:
           echo "package_path=${PACKAGE_PATH}" >> $GITHUB_OUTPUT
           echo "package_filename=$(basename ${PACKAGE_PATH})" >> $GITHUB_OUTPUT
 
+      - name: Sign MSI
+        uses: skymatic/code-sign-action@v3
+        with:
+          certificate: ${{ secrets.microsoft_certificate }}
+          password: ${{ secrets.microsoft_certificate_password }}
+          certificatesha1: ${{ secrets.microsoft_certhash }}
+          description: ${{ secrets.microsoft_description }}
+          folder: ./msi/wix/bin/${{ inputs.package_arch }}/en-US
+
       - name: Store MSI as action artifact
         uses: actions/upload-artifact@v4
         with:

diff --git a/.github/workflows/build_packages.yml b/.github/workflows/build_packages.yml
@@ -142,6 +142,12 @@ jobs:
       apple_developer_certificate_password: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_PASSWORD }}
       productbuild_identity_name: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_IDENTITY }}
       gh_artifacts_token: ${{ secrets.GH_ARTIFACTS_TOKEN }}
+      microsoft_certificate: ${{ secrets.MICROSOFT_CERTIFICATE }}
+      microsoft_certificate_password: ${{ secrets.MICROSOFT_CERTIFICATE_PASSWORD }}
+      microsoft_certhash: ${{ secrets.MICROSOFT_CERTHASH }}
+      microsoft_certname: ${{ secrets.MICROSOFT_CERTNAME }}
+      microsoft_description: ${{ secrets.MICROSOFT_DESCRIPTION }}
+
     strategy:
       matrix:
         include: