Use actions instead of buttons for virtual remotes (#139)

* Remove SVs from EXCLUDED_FROM_SENSOR * Use actions instead of buttons for virtual remotes
SukramJ · Jan 7, 2022 · e36f896 · e36f896
1 parent 1772171
commit e36f896
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 11 deletions.
diff --git a/changelog.txt b/changelog.txt
@@ -1,3 +1,9 @@
+Version 0.15.0 (2022-01-07)
+- Use actions instead of buttons for virtual remotes
+
+Version 0.14.1 (2022-01-06)
+- Remove SVs from EXCLUDED_FROM_SENSOR
+
 Version 0.14.0 (2022-01-06)
 - Switch some HM-LC-Bl1 to cover
 - Use decorators on central methods

diff --git a/hahomematic/device.py b/hahomematic/device.py
@@ -362,7 +362,7 @@ def create_entities(self) -> set[BaseEntity]:
                             parameter_data=parameter_data,
                         )
                         if self._device_address.startswith(tuple(HM_VIRTUAL_REMOTES)):
-                            entity = self.create_button(
+                            entity = self.create_action(
                                 channel_address=channel_address,
                                 parameter=parameter,
                                 parameter_data=parameter_data,
@@ -396,10 +396,10 @@ def create_entities(self) -> set[BaseEntity]:
                 new_entities.extend(custom_entities)
         return set(new_entities)
 
-    def create_button(
+    def create_action(
         self, channel_address: str, parameter: str, parameter_data: dict[str, Any]
-    ) -> HmButton | None:
-        """Create the buttons associated to this device"""
+    ) -> HmAction | None:
+        """Create the actions associated to this device"""
         unique_id = generate_unique_id(
             domain=self._central.domain,
             instance_name=self._central.instance_name,
@@ -408,21 +408,21 @@ def create_button(
             prefix=f"button_{self._central.instance_name}",
         )
         _LOGGER.debug(
-            "create_event: Creating button for %s, %s, %s",
+            "create_event: Creating action for %s, %s, %s",
             channel_address,
             parameter,
             self._interface_id,
         )
 
-        if button := HmButton(
+        if action := HmAction(
             device=self,
             unique_id=unique_id,
             channel_address=channel_address,
             parameter=parameter,
             parameter_data=parameter_data,
         ):
-            button.add_to_collections()
-            return button
+            action.add_to_collections()
+            return action
         return None
 
     def create_event(

diff --git a/hahomematic/helpers.py b/hahomematic/helpers.py
@@ -38,6 +38,8 @@ def generate_unique_id(
 ) -> str:
     """
     Build unique id from address and parameter.
+    Instance_name is addionally used for heating groups.
+    Prefix is used for events and buttons.
     """
     unique_id = address.replace(":", "_").replace("-", "_")
     if parameter:

diff --git a/hahomematic/hub.py b/hahomematic/hub.py
@@ -14,9 +14,7 @@
 _LOGGER = logging.getLogger(__name__)
 
 EXCLUDED_FROM_SENSOR = [
-    "Connection",
     "pcCCUID",
-    "RF-Gateway-Alarm",
 ]
 
 EXCLUDED = [

diff --git a/setup.py b/setup.py
@@ -15,7 +15,7 @@ def readme():
     },
 PACKAGE_NAME = "hahomematic"
 HERE = os.path.abspath(os.path.dirname(__file__))
-VERSION = "0.14.0"
+VERSION = "0.15.0"
 
 PACKAGES = find_packages(exclude=["tests", "tests.*", "dist", "build"])