[IMP][14.0] Purchase_deposit:added button create_deposit

Author: JoanMForgeFlow

purchase_deposit/README.rst

@@ -23,7 +23,7 @@ Purchase Deposit
     :target: https://runbot.odoo-community.org/runbot/142/14.0
     :alt: Try me on Runbot
 
-|badge1| |badge2| |badge3| |badge4| |badge5| 
+|badge1| |badge2| |badge3| |badge4| |badge5|
 
 This module allow purchase order to register deposit similar to that in sales order
 

purchase_deposit/models/purchase.py

@@ -23,7 +23,7 @@ class PurchaseOrderLine(models.Model):
 
     is_deposit = fields.Boolean(
         string="Is a deposit payment",
-        help="Deposit payments are made when creating invoices from a purhcase"
+        help="Deposit payments are made when creating bills from a purhcase"
         " order. They are not copied when duplicating a purchase order.",
     )
 

purchase_deposit/readme/CONFIGURATION.rst

@@ -1,5 +1,5 @@
 After install this module, you need to select the product "Purchase Deposit" in
-configuration window to be used as default product when create deposit invoice.
+configuration window to be used as default product when create deposit bill.
 
 Go to Purchase > Configuration > Settings, then select product "Purchase Deposit"
 

purchase_deposit/readme/CONTRIBUTORS.rst

@@ -1,3 +1,4 @@
 * Dominique K. <dominique.k@elico-corp.com.sg>
 * Kitti Upariphutthiphong <kittiu@ecosoft.co.th>
 * Rattapong Chokmasermkul <rattapongc@ecosoft.co.th>
+* Joan Mateu <joan.mateu@forgeflow.com>

purchase_deposit/readme/USAGE.rst

@@ -1,9 +1,9 @@
 When purchase order is confirmed, a new button "Register Deposit" will appear.
-Normally, deposit will be used to create the 1st invoice (as deposit).
+Normally, deposit will be used to create the 1st bill (as deposit).
 
 #. On confirmed purchase order, click Register Deposit button, wizard will open
-#. 2 type of deposit invoice can be create 1) Down Payment (percentage) 2) Deposit Payment (fixed amount)
-#. Fill in the value and click Create Invoice button.
+#. 2 type of deposit bill can be create 1) Down Payment (percentage) 2) Deposit Payment (fixed amount)
+#. Fill in the value and click Create bill or just create deposit.
 
 As deposit is created, when user click button "Create Bill" again in purchase order,
 the Vendor Bill will be created with deposit amount deducted.

purchase_deposit/tests/test_purchase_deposit.py

@@ -62,6 +62,7 @@ def test_create_deposit_invoice(self):
             "active_id": self.po.id,
             "active_ids": [self.po.id],
             "active_model": "purchase.order",
+            "create_bills": True,
         }
         CreateDeposit = self.env["purchase.advance.payment.inv"]
         self.po.button_confirm()
@@ -125,6 +126,7 @@ def test_create_deposit_invoice_exception(self):
             "active_id": self.po.id,
             "active_ids": [self.po.id],
             "active_model": "purchase.order",
+            "create_bills": True,
         }
         CreateDeposit = self.env["purchase.advance.payment.inv"]
         # 1. This action is allowed only in Purchase Order sate

purchase_deposit/wizard/purchase_make_invoice_advance.py

@@ -206,9 +206,10 @@ def create_invoices(self):
                 }
             )
             del context
-            self._create_invoice(order, po_line, amount)
-        if self._context.get("open_invoices", False):
-            return purchases.action_view_invoice()
+
+            if self._context.get("create_bills", False):
+                self._create_invoice(order, po_line, amount)
+                return purchases.action_view_invoice()
         return {"type": "ir.actions.act_window_close"}
 
     def _prepare_deposit_product(self):

purchase_deposit/wizard/purchase_make_invoice_advance_views.xml

@@ -44,14 +44,14 @@
                 <footer>
                     <button
                         name="create_invoices"
-                        string="Create and View Invoices"
+                        string="Create and View bills"
                         type="object"
-                        context="{'open_invoices': True}"
+                        context="{'create_bills': True}"
                         class="btn-primary"
                     />
                     <button
                         name="create_invoices"
-                        string="Create Invoices"
+                        string="Create deposit"
                         type="object"
                         class="btn-primary"
                     />