Better efficiency & hook compatibility in AsciiTransliterator::intl() #8485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were making a new \Transilterator instance for each call to AsciiTransliterator::toAscii(), which was unnecessary and inefficient. Also, if there was no language-specific transform for transliterating from the forum's default language into Latin characters, then any changes added by mods using the integrate_ascii_transliterator_id hook would end up being discarded. Both issues have now been fixed. Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Sesquipedalian
force-pushed
the
3.0/ascii_transliterator_id
branch
from
04d6c18 to
d68bc08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were making a new \Transilterator instance for each call to AsciiTransliterator::toAscii(), which was unnecessary and inefficient. Also, if there was no language-specific transform for transliterating from the forum's default language into Latin characters, then any changes added by mods using the integrate_ascii_transliterator_id hook would end up being discarded. Both issues have now been fixed.