Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fixes issue #263: ✨ Support for dark theme #431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Fixes issue #263: ✨ Support for dark theme #431

wants to merge 1 commit into from

Conversation

shubham-jitiya-simform
Copy link
Contributor

@shubham-jitiya-simform shubham-jitiya-simform commented Dec 23, 2024 •
edited
Loading

THIS IS DRAFT FOR NOW. DO NOT MERGE

Description

  1. Added support for theme mode light/dark in mobile & web
  2. Added instruction to override in theme_guide.md

Preview

Day-view-dark Day-view-light Month-view-light Month-view-dark Homescreen-dark Homescreen-light Week-view-dark Week-view-dark

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #263, #435

@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/dark_theme_support branch 20 times, most recently from 5d47bbe to b9ba806 Compare December 24, 2024 13:17
@shubham-jitiya-simform shubham-jitiya-simform marked this pull request as ready for review December 24, 2024 13:24
@shubham-jitiya-simform shubham-jitiya-simform mentioned this pull request Dec 30, 2024
Closed
PRBaraiya
PRBaraiya reviewed Jan 2, 2025
View reviewed changes
README.md
@@ -354,6 +354,68 @@ WeekView(

Above code will create `WeekView` with only five days, from monday to friday.

## **Customise theme**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a separate file for theme customization instructions.

@shubham-jitiya-simform shubham-jitiya-simform changed the title feat: Fixes issue #263: Support for dark theme feat: Fixes issue #263: ✨ Support for dark theme Jan 2, 2025
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/dark_theme_support branch 3 times, most recently from f513099 to ef37178 Compare January 2, 2025 12:57
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/dark_theme_support branch 4 times, most recently from 6ef7aee to ca16196 Compare January 7, 2025 10:36
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/dark_theme_support branch 10 times, most recently from 8e41a94 to 283ecdc Compare January 29, 2025 16:27
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/dark_theme_support branch 3 times, most recently from a34efaa to 75d196d Compare February 14, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PRBaraiya PRBaraiya PRBaraiya left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea: Set BackGround Colors :) - Support for dark theme
2 participants
@shubham-jitiya-simform @PRBaraiya