Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ruff check auto-fixes (ignore F401) #623

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

olantwin
Copy link
Contributor

Just the tip of the iceberg, there are over 2k issues found by ruff (including loads of SyntaxErrors!!!!)

Fixed 111 errors:
- field/convertMap.py:
     2 × E703 (useless-semicolon)
- field/convertMisisMap.py:
     2 × E703 (useless-semicolon)
- field/convertNoisyMap.py:
     2 × E703 (useless-semicolon)
- field/convertRALMap.py:
     2 × E703 (useless-semicolon)
- geometry/geometry_config.py:
     1 × E703 (useless-semicolon)
- macro/ShipAna.py:
     3 × E713 (not-in-test)
- macro/ShipReco.py:
     1 × E401 (multiple-imports-on-one-line)
- macro/checkZpositions.py:
     1 × E401 (multiple-imports-on-one-line)
- macro/convertEvtCalc.py:
     1 × F541 (f-string-missing-placeholders)
- macro/dumpEvent.py:
     1 × E401 (multiple-imports-on-one-line)
- macro/evd_addParticleFollower.py:
     1 × E401 (multiple-imports-on-one-line)
- macro/getGeoInformation.py:
     1 × E401 (multiple-imports-on-one-line)
- macro/makeCascade.py:
     1 × E401 (multiple-imports-on-one-line)
- macro/makeDecay.py:
     1 × E401 (multiple-imports-on-one-line)
- macro/makeGenieEvents.py:
     1 × E401 (multiple-imports-on-one-line)
     1 × E713 (not-in-test)
- macro/mergeMbias.py:
     1 × E401 (multiple-imports-on-one-line)
- macro/run_anaEcal.py:
     1 × E401 (multiple-imports-on-one-line)
- macro/run_simEcal.py:
     1 × E401 (multiple-imports-on-one-line)
     1 × E703 (useless-semicolon)
- macro/run_simPgun.py:
     1 × E401 (multiple-imports-on-one-line)
     1 × E703 (useless-semicolon)
- muonShieldOptimization/ana_ShipMuon.py:
     5 × E713 (not-in-test)
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/compactingBackgroundProduction.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/extractMuonsAndUpdateWeight.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/extractNeutrinosAndUpdateWeight.py:
     1 × E401 (multiple-imports-on-one-line)
     1 × F811 (redefined-while-unused)
- muonShieldOptimization/g4Ex.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/g4Ex_args.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/g4Ex_gap.py:
     1 × E401 (multiple-imports-on-one-line)
     1 × F811 (redefined-while-unused)
- muonShieldOptimization/g4Ex_gap_mergeFiles.py:
     1 × E401 (multiple-imports-on-one-line)
     1 × E713 (not-in-test)
- muonShieldOptimization/makeMuonDIS.py:
     1 × E401 (multiple-imports-on-one-line)
     1 × E713 (not-in-test)
- muonShieldOptimization/makeMuonEM.py:
     1 × E401 (multiple-imports-on-one-line)
     1 × E713 (not-in-test)
- muonShieldOptimization/muDIS_mergeFiles.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/runCharmHadProd.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/run_fixedTarget.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/run_prod.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/run_reco.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/study_GammaConv.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/study_muEloss.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/study_muMSC.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/study_thinTarget.py:
     1 × E401 (multiple-imports-on-one-line)
- muonShieldOptimization/submitPyG4prod.py:
     1 × E401 (multiple-imports-on-one-line)
- python/CMBG_conf.py:
     1 × E401 (multiple-imports-on-one-line)
     1 × E703 (useless-semicolon)
- python/PythiaList.py:
     1 × E401 (multiple-imports-on-one-line)
- python/ShieldUtils.py:
    19 × E703 (useless-semicolon)
- python/TTCluster.py:
     4 × E714 (not-is-test)
- python/checkMagFields.py:
     1 × E401 (multiple-imports-on-one-line)
- python/darkphoton.py:
     2 × E703 (useless-semicolon)
- python/dpProductionRates.py:
     1 × E401 (multiple-imports-on-one-line)
- python/genie_interface.py:
     1 × E401 (multiple-imports-on-one-line)
- python/geomGeant4.py:
     2 × E713 (not-in-test)
- python/goliath2root.py:
     1 × E401 (multiple-imports-on-one-line)
- python/hnl.py:
     1 × E401 (multiple-imports-on-one-line)
- python/pi0Reco.py:
     1 × E401 (multiple-imports-on-one-line)
- python/proton_bremsstrahlung.py:
     1 × E401 (multiple-imports-on-one-line)
- python/pythia8darkphoton_conf.py:
     1 × E401 (multiple-imports-on-one-line)
- python/readDecayTable.py:
     1 × E401 (multiple-imports-on-one-line)
- python/rootUtils.py:
     2 × E401 (multiple-imports-on-one-line)
     1 × E713 (not-in-test)
- python/saveBasicParameters.py:
     1 × E401 (multiple-imports-on-one-line)
- python/shipDigiReco.py:
     1 × E401 (multiple-imports-on-one-line)
     1 × E713 (not-in-test)
     1 × F841 (unused-variable)
- python/shipMuShield_only.py:
     1 × E401 (multiple-imports-on-one-line)
- python/shipPid.py:
     1 × E401 (multiple-imports-on-one-line)
- python/shipStrawTracking.py:
     3 × F811 (redefined-while-unused)
- python/shipTarget_only.py:
     1 × E401 (multiple-imports-on-one-line)
- python/shipVertex.py:
     1 × E401 (multiple-imports-on-one-line)

@olantwin
Copy link
Contributor Author

Considering how many side-effects our modules have, I'm quite worries about any of the import re-orderings involving our modules. They need to be checked carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant