Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git-lfs to track ROOT files #611

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Use git-lfs to track ROOT files #611

merged 2 commits into from
Feb 27, 2025

Conversation

olantwin
Copy link
Contributor

No description provided.

@olantwin olantwin requested a review from a team as a code owner February 12, 2025 13:29
@olantwin olantwin force-pushed the lfs branch 2 times, most recently from f05939c to be9958b Compare February 18, 2025 15:58
@olantwin
Copy link
Contributor Author

@egamberini It seems like it causes issues for the CI if we use git-lfs to store ROOT files. Is this something we need to fix on the runners?

@egamberini
Copy link
Collaborator

Weird, I can't reproduce the error locally while using the gha-runner container, so it doesn't seem to be a missing dependency in the container itself.
The runner VM and its OS shouldn't affect what happens inside the container, but I'll investigate further tomorrow....

@olantwin
Copy link
Contributor Author

Weird, I can't reproduce the error locally while using the gha-runner container, so it doesn't seem to be a missing dependency in the container itself.
The runner VM and its OS shouldn't affect what happens inside the container, but I'll investigate further tomorrow....

Thanks for the quick reply!

@olantwin
Copy link
Contributor Author

@egamberini Did you have a chance to investigate why the runner fails?

@olantwin
Copy link
Contributor Author

Alternatively, we might want to just move these files to EOS.

@egamberini
Copy link
Collaborator

I've managed to reproduce the error on different environments:

  • container in runner VM
  • container on local computer
  • local computer

Only works on lxplus in my tests.

Therefore there must be a missing dep (maybe a python package or pyrooot extension that's present on lxplus system-wide and needs to be explicitly installed on other environments).
I've tried installing git-lfs as a system package but doesn't help.

Executing pip list | grep lfs on lxplus doesn't match anything.

I'm at a loss of ideas.

@olantwin
Copy link
Contributor Author

@egamberini I think we're a step further, now it complains about the git-lfs executable missing.

@egamberini
Copy link
Collaborator

Nice! I've pushed a new container with git-lfs installed. That fixed the CI seems like...

@olantwin olantwin merged commit d2d561f into master Feb 27, 2025
2 checks passed
@olantwin olantwin deleted the lfs branch February 27, 2025 14:28
@olantwin
Copy link
Contributor Author

Nice! I've pushed a new container with git-lfs installed. That fixed the CI seems like...

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants