Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cavern Mismatch #609

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix Cavern Mismatch #609

merged 1 commit into from
Feb 12, 2025

Conversation

Gfrisella
Copy link
Contributor

Fixed the cavern mismatch TCC8 and ECN3.
image(1)

@Gfrisella Gfrisella requested a review from a team as a code owner February 11, 2025 18:44
olantwin
olantwin requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@olantwin olantwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, this also fixes the overlaps with the muon shield.

Could you please move the changelog entry to the Unreleased heading?

@olantwin olantwin mentioned this pull request Feb 11, 2025
Closed
@olantwin olantwin merged commit 20f685c into ShipSoft:master Feb 12, 2025
0 of 2 checks passed
@olantwin olantwin mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olantwin olantwin olantwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gfrisella @olantwin